fix(qt): keep PoSe score visible when hiding banned masternodes#7298
fix(qt): keep PoSe score visible when hiding banned masternodes#7298thepastaclaw wants to merge 1 commit into
Conversation
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe "Hide banned" checkbox handler in the masternode list was modified to remove the logic that hid the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit 1d9e004) |
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Minimal one-line fix that correctly decouples the POSE column visibility from the 'Hide banned' filter. The previous behavior was asymmetric (toggling on hid the column but toggling off never restored it). The proxy filter still excludes banned rows. Both reviewers converged on a single test-coverage suggestion; no blocking issues.
Reviewed commit: 1d9e004
💬 1 nitpick(s)
1 additional finding
💬 nitpick: No Qt test covers the Hide Banned / PoSe column behavior
src/qt/masternodelist.cpp (lines 291-300)
The fix lives entirely in MasternodeList::on_checkBoxHideBanned_stateChanged, but no test under src/qt/test/ exercises MasternodeList. The Qt test harness already exists in src/qt/test/test_main.cpp, so a focused test that toggles checkBoxHideBanned and asserts both the filtered row count and that tableViewMasternodes->isColumnHidden(MasternodeModel::POSE) remains false would prevent the same regression from reappearing. Not blocking — the fix is small and correct — but the original bug slipped through precisely because there was no automated coverage of this surface.
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Single-line Qt fix that correctly stops the 'Hide banned' toggle from also hiding the PoSe Score column. Both reviewers converge on the same nitpick — no Qt test coverage for this widget interaction. No blocking issues.
Reviewed commit: 1d9e004
Fresh dispatcher run for this queue item. A same-SHA review already existed, so this records the fresh verification without duplicating inline threads.
Code Review
Reviewed commit: 1d9e004
💬 1 nitpick(s)
thepastaclaw
force-pushed
the
fix/masternode-hide-banned-keep-pose
branch
from
1d9e004 to
536f388
Compare
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
PR #7298 is a minimal one-line Qt fix to MasternodeList::on_checkBoxHideBanned_stateChanged that decouples the PoSe Score column visibility from the 'Hide banned' filter. Banned-row filtering still happens via the proxy model (setHideBanned + forceInvalidateFilter), while the PoSe column remains visible — which is desirable since non-zero PoSe scores warn of pre-ban state. The latest delta from 1d9e004 to 536f388 contains only unrelated develop-branch merges; src/qt/masternodelist.cpp is unchanged between the prior review and current head, so the sole carried-forward nitpick (no Qt test covering this interaction) remains valid. No blocking issues, no new latest-delta findings.
💬 1 nitpick(s)
1 additional finding(s) omitted (not in diff).
3 participants
PR description
Summary
checked.
Closes #7286.
Validation
git diff --checkthis worktree.